-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Tuesday, May 5, 2026 6:45 AM
To: Selvamani Rajagopal <redacted>
Cc: Piergiorgio Beruto <redacted>; andrew+netdev@lunn.ch;
davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
krzk+dt@kernel.org; conor+dt@kernel.org; netdev@vger.kernel.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/5] dt-bindings: net: add onsemi's TS2500/NCN26010
10BASE-T1S MACPHY


This Message Is From an External Sender
This message came from outside your organization.

On Fri, May 01, 2026 at 07:15:17PM +0000, Selvamani Rajagopal wrote:

quoted

Add YAML device tree binding for the onsemi NCN26010 and TS2500
IEEE 802.3cg compliant Ethernet transceiver devices.

Signed-off-by: Selvamani Rajagopal <redacted>
---
.../bindings/net/onnn,ncn260xx.yaml | 71 +++++++++++++++++++
1 file changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml

diff --git a/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml

b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml

quoted

new file mode 100644
index 000000000..198cd7e9d

--- /dev/null
+++ b/Documentation/devicetree/bindings/net/onnn,ncn260xx.yaml

@@ -0,0 +1,71 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/onnn,ncn260xx.yaml#

<http://devicetree.org/schemas/net/onnn,ncn260xx.yaml#
vicetree.org>

quoted

+$schema: http://devicetree.org/meta-schemas/core.yaml#

<http://devicetree.org/meta-schemas/core.yaml#
n=devicetree.org>

quoted

+
+title: onsemi NCN26010/TS2500 10BASE-T1S MACPHY Ethernet Controllers
+
+maintainers:
+ - Piergiorgio Beruto [off-list ref]
+ - Selva Rajagopal [off-list ref]
+
+description: |
+ The NCN26010 and TS2500 combine a Media Access Controller (MAC) and an
+ Ethernet PHY to enable 10BASE‑T1S networks. The Ethernet Media Access
+ Controller (MAC) module implements a 10 Mbps half duplex Ethernet MAC,
+ compatible with the IEEE 802.3 standard and a 10BASE-T1S physical layer
+ transceiver integrated into the NCN26010. The communication between
+ the host and the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x
+ MACPHY Serial Interface (TC6).
+
+ Specifications about the NCN26010 can be found at:
+ https://www.onsemi.com/download/data-sheet/pdf/ncn26010-d.pdf

<https://www.onsemi.com/download/data-sheet/pdf/ncn26010-d.pdf
n=onsemi.com>

quoted

+ https://www.onsemi.com/products/interfaces/ethernet-controllers/t30hm1ts2500

<https://www.onsemi.com/products/interfaces/ethernet-controllers/t30hm1ts2500
semi.com>

quoted

+
+allOf:
+ - $ref: /schemas/net/ethernet-controller.yaml#
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+ compatible:
+ const: onnn,ncn260xx

Don't use wildcards in compatible strings.

quoted

+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ description: |

Don't need '|'.

quoted

+ Interrupt from MAC-PHY asserted in the event of Receive Chunks
+ Available, Transmit Chunk Credits Available and Extended Status
+ Event.
+ maxItems: 1
+
+ spi-max-frequency:
+ minimum: 15000000

A minimum is strange. What if you have a board issue requiring lower
frequency?

Had the same question in internal review. Datasheet says the minimum speed 15 MHz is needed. That's why we had placed.

quoted

+ maximum: 25000000
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - spi-max-frequency

Normally this is not required. It's only for boards which can't operate
at the maximum frequency of the device.

quoted

+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet@0 {
+ compatible = "onnn,ncn260xx";
+ reg = <0>;
+ pinctrl-names = "default";
+ interrupt-parent = <&gpio>;
+ interrupts = <25 2>;
+ status = "okay";

Drop. Examples are always enabled.

quoted

+ spi-max-frequency = <25000000>;
+ };
+ };
--
2.43.0


Public Information