[PATCH RESEND] net: stmmac: fix RX DMA leak on TX alloc failure
From: Abid Ali via B4 Relay <devnull+dev.taqnialabs.gmail.com@kernel.org>
Date: 2026-05-05 08:23:15
Also in:
b4-sent, linux-arm-kernel, lkml
Subsystem:
networking drivers, stmmac ethernet driver, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Abid Ali <redacted> Free RX DMA resources when alloc_dma_tx_desc_resources() fails in alloc_dma_desc_resources(). Signed-off-by: Abid Ali <redacted> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 13d3cac05..8bb843b55 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c@@ -2370,8 +2370,12 @@ static int alloc_dma_desc_resources(struct stmmac_priv *priv, return ret; ret = alloc_dma_tx_desc_resources(priv, dma_conf); + if (ret) { + free_dma_rx_desc_resources(priv, dma_conf); + return ret; + } - return ret; + return 0; } /**
--- base-commit: 028ef9c96e96197026887c0f092424679298aae8 change-id: 20260425-stmmac-rx-desc-cleanup-440f05845492 Best regards, -- Abid Ali [off-list ref]