Re: [PATCH net-next v2 1/2] dpll: move fractional-frequency-offset-ppt under pin-parent-device
From: Ivan Vecera <ivecera@redhat.com>
Date: 2026-05-04 09:36:36
Also in:
linux-doc, linux-rdma, lkml
From: Ivan Vecera <ivecera@redhat.com>
Date: 2026-05-04 09:36:36
Also in:
linux-doc, linux-rdma, lkml
Hi Jiri, On 5/4/26 10:48 AM, Jiri Pirko wrote:
Thu, Apr 30, 2026 at 07:36:10PM +0200, ivecera@redhat.com wrote:quoted
Move the fractional-frequency-offset-ppt attribute from the top-level pin attributes into the pin-parent-device nested attribute set. This makes it consistent with phase-offset which is already per-parent and clarifies that FFO PPT represents the frequency difference between a pin and its parent DPLL device. The top-level fractional-frequency-offset attribute (in PPM) remains unchanged for backward compatibility.That is odd. The ppt one was added just for higher precision but was semantically the same. Now you change it. Could you still treat both the same?
WDYM? Keep fractional-frequency-offset-ppt at the top-level and add both fractional-frequency-offset and fractional-frequency-offset-ppt into pin-parent-device nested attribute set? Thanks, Ivan