Thread (17 messages) 17 messages, 5 authors, 7d ago

Re: [PATCH 0/6] lib: rework bitreverse

From: Yury Norov <hidden>
Date: 2026-05-02 01:40:11
Also in: bpf, linux-arch, linux-riscv, lkml

On Thu, Apr 30, 2026 at 05:13:44PM -0400, Yury Norov wrote:
This series is a resend for Jinjie Ruan's "arch/riscv: Add bitrev.h file
to support rev8 and brev8" [1], my follow-up "lib: compile generic
bitrev based on GENERIC_BITREVERSE" [2], and the fix for a build error
reported by Nathan Chancellor [3].

No changes, except for combining pieces together and rebasing on top of
the tree.

[1] https://lore.kernel.org/all/20260421130752.607500-1-ruanjinjie@huawei.com/ (local)
[2] https://lore.kernel.org/all/20260427205210.397471-1-ynorov@nvidia.com/ (local)
[3] https://lore.kernel.org/all/20260429202922.GA3575295@ax162/ (local)

Build-tested against x86 tinyconfig and defconfig, having disabled and
enabiled CRC32 and BITREVERSE, correspondingly.
I've got a feedback from sashiko bot.

1. We need to do #if IS_DEFINED(CONFIG_CRC32) instead of #ifdef,
   because it may be a module.
2. Selecting GENERIC_BITREVERSE without BITREVERSE causes the unmet
   direct dependency warning:

   WARNING: unmet direct dependencies detected for GENERIC_BITREVERSE
  Depends on [n]: BITREVERSE [=n]
  Selected by [m]:
  - MYCONFIG [=m]

I'll send a v2 to fix it

Thanks,
Yury
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help