Thread (3 messages) 3 messages, 2 authors, 2026-05-29

Re: [PATCH net-next v2] doc/netlink: rt-link: fix binary attributes marked as strings

flat view

From: Remy D. Farley <hidden>
Date: 2026-05-29 12:10:06

On Friday, May 29th, 2026 at 00:34, Jakub Kicinski [off-list ref] wrote:
On Tue, 26 May 2026 23:04:56 +0000 Remy D. Farley wrote:
quoted
These link-attrs attributes were previously marked as strings:

- wireless - struct iw_event
- protinfo - a nest of ifla6-attrs or linkinfo-brport-attrs
- cost, priority - unused
quoted
       -
         name: cost
-        type: string
+        type: binary
	type: unused

is a thing, should we use it instead of binary?

Yeah, this looks more useful. The neighboring rt-route seems to prefer
"type: binary", but I guess that's just an omission.

|       -
|         name: mp-algo  # not used
|         type: binary

IIRC it's expected to never exist in messages but to still output
an entry into uAPI, which I think matches the situation here.

If_link uapi header isn't generated, so no changes there.

Sorry, should have looked closer at v1.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help