-----Original Message-----
From: Jacob Keller <jacob.e.keller@intel.com>
Sent: Wednesday, May 27, 2026 4:36 PM
To: David Thompson <davthompson@nvidia.com>;
bryan.whitehead@microchip.com; UNGLinuxDriver@microchip.com;
andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
kuba@kernel.org; pabeni@redhat.com
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: lan743x: add "message level" module
parameter

On 5/27/2026 11:18 AM, David Thompson wrote:

quoted

The lan743x driver currently hardcodes the initial value of the
msg_enable parameter during probe(), and uses this value for netdev

message logging.

quoted

Instead, the driver should provide a "message level" module parameter
to allow users to configure the logging level at load time.

Signed-off-by: David Thompson <davthompson@nvidia.com>
---
v2:
- new patch added in v2
---
 drivers/net/ethernet/microchip/lan743x_main.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/microchip/lan743x_main.c

b/drivers/net/ethernet/microchip/lan743x_main.c
index f3332417162e..793633cced19 100644

--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c

@@ -28,6 +28,17 @@

 #define RFE_RD_FIFO_TH_3_DWORDS	0x3

+#define LAN743X_DEF_MSG_ENABLE \
+	(NETIF_MSG_DRV      | \
+	 NETIF_MSG_PROBE    | \
+	 NETIF_MSG_LINK     | \
+	 NETIF_MSG_IFUP     | \
+	 NETIF_MSG_IFDOWN   | \
+	 NETIF_MSG_TX_QUEUED)
+static int lan743x_msg_enable = -1;
+module_param(lan743x_msg_enable, int, 0);
+MODULE_PARM_DESC(lan743x_msg_enable, "Debug message level");
+

I guess many drivers have msg_enable parameters already so  this isn't "new",
but the netdev maintainers have frowned on adding any module parameters
for years.

This patch has received two bits of negative feedback:

1) It causes a CI test failure:
	netdev/deprecated_api	fail	Found: 'module_param' was: 0 now: 1

2) Also, Jakub Kicinski asked me to not pursue this type of change

So, this patch will be retracted from the patch series.

I will create a v3 patch for net-next to address all feedback.

- Dave