[PATCH net v3] net: txgbe: fix phylink leak on AML init failure

From
Chenguang Zhao <hidden>
Date
2026-05-28 01:33:02
Destroy the phylink instance when fixed-link setup fails.

Fixes: 6f8b4c01a8cd ("net: txgbe: Implement PHYLINK for AML 25G/10G devices")
Signed-off-by: Chenguang Zhao <redacted>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
v3:
 - Adjusted the subject prefix as suggested by Maxime.
v2:
 https://lore.kernel.org/all/20260526090559.2095680-1-zhaochenguang@kylinos.cn/ (local)
v1:
 https://lore.kernel.org/all/20260522070749.1634542-1-zhaochenguang@kylinos.cn/ (local)
---
 drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
index f0514251d4f3..8e301e7d1148 100644
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_aml.c
@@ -521,6 +521,7 @@ int txgbe_phylink_init_aml(struct txgbe *txgbe)
 	err = phylink_set_fixed_link(phylink, &state);
 	if (err) {
 		wx_err(wx, "Failed to set fixed link\n");
+		phylink_destroy(phylink);
 		return err;
 	}
 
-- 
2.25.1
Thread (2 messages) 2 messages, 2 authors, last reply 2026-06-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help