On Wed, May 27, 2026 at 5:22 PM Jakub Kicinski [off-list ref] wrote:

On Tue, 26 May 2026 01:51:17 +0000 Kuniyuki Iwashima wrote:

quoted

-     if (data[IFLA_GENEVE_REMOTE] && data[IFLA_GENEVE_REMOTE6]) {
+     if ((data[IFLA_GENEVE_REMOTE] && data[IFLA_GENEVE_REMOTE6]) ||
+         (data[IFLA_GENEVE_LOCAL] && data[IFLA_GENEVE_LOCAL6]) ||
+         (data[IFLA_GENEVE_REMOTE] && data[IFLA_GENEVE_LOCAL6]) ||
+         (data[IFLA_GENEVE_REMOTE6] && data[IFLA_GENEVE_LOCAL])) {

nit: Looks like a cartesian product, perhaps:

        if ((data[IFLA_GENEVE_LOCAL] || data[IFLA_GENEVE_REMOTE]) &&
            (data[IFLA_GENEVE_LOCAL6] || data[IFLA_GENEVE_REMOTE6]))

? at the very least would be good if the last line also had v4 one the
left.

This looks better.

But, more importantly - I think the AI reviewers are right,
please update Documentation/netlink/specs/rt-link.yaml to add these
new attrs

Ah, I thought the ynl spec didn't cover each driver.
I'll add a few lines.

If you can think of something meaningful / useful in surfacing
potential bugs maybe also a selftest?

I'll add it once the iproute2 patch is merged.

Thanks !