on 2026/5/27 17:59, Simon Horman wrote:

On Sat, May 23, 2026 at 06:54:43PM +0800, Jijie Shao wrote:

quoted

This patchset enhances the tc flow offload support for hns3 driver:

- Patch 1: Refactor hclge_add_cls_flower() to support more actions
- Patch 2: Improve unused_tuple parameter setting for separate src/dst configuration
- Patch 3: Add support for HCLGE_FD_ACTION_SELECT_QUEUE and HCLGE_FD_ACTION_DROP_PACKET actions
- Patch 4: Add support for FLOW_DISSECTOR_KEY_IP and FLOW_DISSECTOR_KEY_ENC_KEYID dissectors
- Patch 5: Add debugfs support for dumping FD rules
- Patch 6: Move FD code to a separate file (hclge_fd.c) for better code organization

---
ChangeLog:
v1 -> v2:
   - Fixed warnings similar to "warning: restricted __le32 degrades to integer",
     pointed out by Jakub
   - Fixed warnings related to
     "warning: diagnostic behavior may be improved by adding the 'format(printf, 5, 7)'",
     pointed out by Jakub
   v1: https://lore.kernel.org/all/20260518093526.1109595-1-shaojijie@huawei.com/ (local)

Hi Juijie,

There are AI-generated reviews of this patch-set available at
https://netdev-ai.bots.linux.dev/ and https://sashiko.dev/

Hi,

I'm sorry, I don't understand how to use https://netdev-ai.bots.linux.dev/, it seems to require an API Token?
I find it difficult to locate my own patch-set in Recent Reviews.


Regarding https://sashiko.dev/, I checked and some of the issues are pre-existing issues,
not caused by the new features added in this patch-set.

Some others are related to the solution, which is the same as the ethtool -U  already supported by the driver.
I suggest keeping it consistent with ethtool -U for now.
I will also check later whether modifications are needed. If the suggestion is reasonable,
I will send a separate patch to fix the code for both tc flow and ethtool -U.

For the remaining issues related to debugfs, I suggest they can be rejected.

Thanks,
Jijie Shao