Thread (8 messages) 8 messages, 4 authors, 2026-05-28

Re: [PATCH net 2/3] dpll: zl3073x: use __dpll_device_change_ntf() and remove change_work

From: Ivan Vecera <ivecera@redhat.com>
Date: 2026-05-27 07:51:53
Also in: lkml

On 5/26/26 9:45 AM, Ivan Vecera wrote:
The change_work was introduced to send device change notifications
from DPLL device callbacks without deadlocking on dpll_lock, since
the callbacks are already invoked under that lock. Now that
__dpll_device_change_ntf() is exported for callers that already
hold dpll_lock, use it directly and remove the change_work
infrastructure entirely.

This eliminates a race condition where change_work could be
re-scheduled after cancel_work_sync() during device teardown,
potentially causing the handler to dereference a freed or NULL
dpll_dev pointer.

Fixes: 9363b4837659 ("dpll: zl3073x: Allow to configure phase offset averaging factor")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Hi Kuba & Paolo,

patchwork reported netdev/build_allmodconfig_warn failure for this
patch. But it looks weird:

https://netdev-ctrl.bots.linux.dev/logs/build/1100767/14594344/build_allmodconfig_warn/stderr

I don't understand how this is related to this patch.

Thanks,
Ivan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help