Hi Andrew,
Thanks for review comments.

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: Thursday, May 14, 2026 6:09 PM
To: Thangaraj Samynathan - I53494 <Thangaraj.S@microchip.com>
Cc: netdev@vger.kernel.org; andrew+netdev@lunn.ch;
davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
pabeni@redhat.com; Bryan Whitehead - C21958
[off-list ref]; UNGLinuxDriver
[off-list ref]; linux@armlinux.org.uk; linux-
kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/5] net: lan743x: rename is_sgmii_en to is_pcs_en

EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe

On Thu, May 14, 2026 at 04:20:24PM +0530, Thangaraj Samynathan wrote:

quoted

The flag is_sgmii_en indicates whether the PCS interface is enabled.
However, the name implies that the interface is strictly SGMII, which
is misleading.

Rename the variable to is_pcs_en to better reflect that the flag
represents the PCS enable state rather than a specific interface mode.
Update all references and logs accordingly (but keep device registers
unchanged to match its documentation).

So the documentation is also broken?

Can you get the documentation fixes, and then replace all references of SGMII
to PCS?

[Thangaraj Samynathan] , Datasheets for this product are already released to
customers, are not under our control, and cannot be reverted. For this product,
these changes can be only done in the code at this time. We will provide feedback
to the hardware architecture team - datasheets evolve from their architecture
specifications - strongly recommending that the terminology should be changed to 
PCS" in future products 

quoted

-     if (adapter->is_pci11x1x && adapter->is_sgmii_en)
+     if (adapter->is_pci11x1x && adapter->is_pcs_en)
              adapter->phy_interface = PHY_INTERFACE_MODE_SGMII;

Maybe this is in a later patch in this series, but i assume
PHY_INTERFACE_MODE_1000BASEX is also a potential mode?

[Thangaraj Samynathan] Yes, the hardware support 1000BASEX too. 

        Andrew