RE: [PATCH net-next v2 2/2] net: lan743x: add support for RMII interface
From: <Thangaraj.S@microchip.com>
Date: 2026-05-27 03:23:06
Also in:
lkml
Hi Andrew, Thanks for the comments.
-----Original Message----- From: Andrew Lunn <andrew@lunn.ch> Sent: Tuesday, May 26, 2026 10:20 PM To: Thangaraj Samynathan - I53494 <Thangaraj.S@microchip.com> Cc: netdev@vger.kernel.org; andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Bryan Whitehead - C21958 [off-list ref]; UNGLinuxDriver [off-list ref]; linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 2/2] net: lan743x: add support for RMII interface EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Tue, May 26, 2026 at 09:10:54PM +0530, Thangaraj Samynathan wrote:quoted
Enable RMII interface in the lan743x driver for PHY and MAC configuration. - Select RMII interface in lan743x_phy_interface_select(). - Update phylink supported_interfaces and MAC capabilities. - Enable RMII via RMII_CTL in lan743x_hardware_init(). - Define RMII_CTL register and enable bit in lan743x_main.h.quoted
+ case PHY_INTERFACE_MODE_RMII: + __set_bit(PHY_INTERFACE_MODE_RMII, + adapter->phylink_config.supported_interfaces); + adapter->phylink_config.lpi_capabilities = 0;So EEE is not supporting with RMII? This is not mentioned in the commit message. Humm, is this an 802.3 limitation, or a limitation of this hardware? If this is 802.3, then this should be in phylink, not drivers.
[Thangaraj Samynathan] No. This is the limitation of hardware. Will update The commit message in next revision.
Andrew