Re: [PATCH net-next 4/4] net: make page_pool_get_stats() void

From
Nicolai Buchwitz <nb@tipi-net.de>
Date
2026-05-26 19:36:24
Also in
linux-doc
Reply to
Jakub Kicinski, 2026-05-26
On 26.5.2026 17:57, Jakub Kicinski wrote:
The kdoc for page_pool_get_stats() is missing a Returns: statement.
Looking at this function, I have no idea what is the purpose of
the bool it returns. My guess was that maybe the static inline
stub returns false if CONFIG_PAGE_POOL_STATS=n but such static
inline helper doesn't exist at all. All callers pass a pointer
to a struct on the stack. Make this function void.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
[...]
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
Thread (11 messages) 11 messages, 4 authors, last reply 2026-05-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help