Re: [PATCH net 1/9] ethtool: module: call ethnl_ops_complete() on module flash errors
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: 2026-05-23 14:29:13
Hi, On 5/23/26 01:13, Jakub Kicinski wrote:
When validate() fails we are skipping over ethnl_ops_complete()
even tho we already called ethnl_ops_begin().
Fixes: 32b4c8b53ee7 ("ethtool: Add ability to flash transceiver modules' firmware")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Maxime
quoted hunk ↗ jump to hunk
--- CC: andrew@lunn.ch CC: kees@kernel.org CC: maxime.chevallier@bootlin.com CC: petrm@nvidia.com CC: danieller@nvidia.com --- net/ethtool/module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/net/ethtool/module.c b/net/ethtool/module.c index cad2eb25b5a4..741f6fb25d45 100644 --- a/net/ethtool/module.c +++ b/net/ethtool/module.c@@ -427,10 +427,11 @@ int ethnl_act_module_fw_flash(struct sk_buff *skb, struct genl_info *info) ret = ethnl_module_fw_flash_validate(dev, info->extack); if (ret < 0) - goto out_unlock; + goto out_complete; ret = module_flash_fw(dev, tb, skb, info); +out_complete: ethnl_ops_complete(dev); out_unlock: