Thread (4 messages) 4 messages, 4 authors, 2026-05-22

Re: [PATCH net-next] net: e100: remove redundant static variable initializations

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-05-22 15:55:24
Also in: intel-wired-lan, lkml

On Fri, 22 May 2026 12:22:30 +0530 Ashwin Gundarapu wrote:
Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
Static variables are zero-initialized by default.

Found by checkpatch.pl
Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help