Thread (14 messages) 14 messages, 6 authors, 28d ago

Re: [PATCH net-next v2 0/5] Consolidate FCrypt and PCBC code into net/rxrpc/

From: Marc Dionne <hidden>
Date: 2026-05-22 13:07:01
Also in: linux-crypto, lkml

On Fri, May 22, 2026 at 2:07 AM Eric Biggers [off-list ref] wrote:
The FCrypt "block cipher" and the PCBC mode of operation are obsolete
and insecure.  Since their only user is net/rxrpc/, they belong there,
not in the crypto API.

Therefore, this series removes these algorithms from the crypto API and
replaces them with local implementations in net/rxrpc/.

The local implementations are simpler too, as they avoid the crypto API
boilerplate.

I don't know how to test all the code in net/rxrpc/, but everything
should still work.  I added a KUnit test for the crypto functions.

Changed in v2:
    - Added missing export of fcrypt_preparekey().
    - Write "RxRPC crypto KUnit test" instead of "RxRPC KUnit test".
    - Rebased onto latest net-next where decryption now happens in the
      linear buffer rxrpc_call::rx_dec_buffer, simplifying the code.
Looks good in testing with our kafs test suite, forcing the use of
rxkad with encryption.

Feel free to add for the series:
Tested-by: Marc Dionne <marc.dionne@auristor.com>

Marc
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help