Thread (2 messages) 2 messages, 2 authors, 19d ago

Re: [PATCH iwl-net] ice: fix LAG recipe to profile association

From: Simon Horman <horms@kernel.org>
Date: 2026-05-22 08:42:22
Also in: intel-wired-lan

On Tue, May 19, 2026 at 01:20:41PM +0200, Marcin Szycik wrote:
ice_init_lag() associates recipes to profiles, assuming that Link
Aggregation-related profiles will always have profile ID lower than 70
(ICE_PROFID_IPV6_GTPU_IPV6_TCP_INNER). This value seems arbitrary and
might not always be valid for some versions of DDP package, i.e. LAG
profiles may have profile ID greater than 70. This would lead to
misconfigured switch and LAG not working properly.

Fix it by checking up to maximum profile ID.

Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface")
Signed-off-by: Marcin Szycik <redacted>
Reviewed-by: Michal Swiatkowski <redacted>
Reviewed-by: Aleksandr Loktionov <redacted>
Reviewed-by: Dave Ertman <david.m.ertman@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>

I notice that there is an AI review of this patch available on sashiko.dev.
However, I believe that flags a pre-existing problem that is orthogonal to
this patch. o I do no think that review should block progress of this
patch but rather be looked at in the context of possible follow-up.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help