On Wed, May 20, 2026 at 08:33:28AM +0200, Oscar Maes wrote:

napi_complete_done may call gro_flush_normal (though not currently, as GRO
is unsupported at the moment), which may result in packet TX. This will
eventually result in calling pcnet32_start_xmit - resulting in a deadlock
while trying to re-acquire the already locked spin lock.

Please continue to commit message with something like:

  It is safe to release the spinlock, because it is protecting X,
  which is not modified during the time the spinlock is released.

You need to convince us this is safe.


    Andrew

---
pw-bot: cr