Thread (8 messages) 8 messages, 3 authors, 2026-05-06
COLD43d

[PATCH net 0/3] pull request: fixes for ovpn 2026-05-04

From: Antonio Quartulli <antonio@openvpn.net>
Date: 2026-05-04 23:03:38

Hello netdev team,

Here is a respin of the previous PR, after gathering an extra review
from sashiko. This PR also includes an extra fix for the selftests.

Patch 1 is ensuring that the MAC header offset is reset before
deliering the packet to the upper layer. Not doing so could trick other
parts of the networking stack into wrong calculations.

Patch 1 fixes the inconsistent call context for gro_cells_receive() and
dev_dstats_rx_add().
On a TCP connection, we can end up calling gro_cells_receive() from
process context, which is unexpected (and could potentially trigger
deadlocks). At the same time, also dev_dstats_rx_add() should not be
invoked concurrently on the same CPU (i.e. from a softirq).
For this reason we're wrapping the aforementioned calls within
local_bh_disable/enable().


Ideally all selftests should always succeed now.

Please pull or let me know of any issue.

Thanks,
	Antonio


The following changes since commit bd3a4795d5744f59a1f485379f1303e5e606f377:

  selftests: tls: add test for data loss on small pipe (2026-05-02 18:27:14 -0700)

are available in the Git repository at:

  https://github.com/OpenVPN/ovpn-net-next.git tags/ovpn-net-20260504

for you to fetch changes up to 201ba706318d460a2ea660e3652610be62532a70:

  selftests: ovpn: reduce ping count in test.sh (2026-05-05 00:31:11 +0200)

----------------------------------------------------------------
Includes changes:
* ensure MAC header offset is reset before delivering packet
* ensure gro_cells_receive() and dstats_dev_add() are called with BH
  disabled
* reduce ping count in selftest to ensure it completes within
  timeout

----------------------------------------------------------------
Qingfang Deng (1):
      ovpn: reset MAC header before passing skb up

Ralf Lici (2):
      ovpn: ensure packet delivery happens with BH disabled
      selftests: ovpn: reduce ping count in test.sh

 drivers/net/ovpn/io.c                    | 7 +++++++
 tools/testing/selftests/net/ovpn/test.sh | 4 ++--
 2 files changed, 9 insertions(+), 2 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help