Re: [PATCH net-next] net: gianfar: use alloc_ethdev_mqs
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-04-28 23:13:17
Also in:
lkml
On Tue, Apr 28, 2026 at 03:30:58PM -0700, Rosen Penev wrote:
quoted hunk ↗ jump to hunk
quoted
From looking at git history, mqs was introduced after mq and after thiscode was written. Having said that, mqs can be used as there is already an RX queue variable in place. Not only that, mqs already sets the num_xx_queues members. No need to open code this. Signed-off-by: Rosen Penev <redacted> --- drivers/net/ethernet/freescale/gianfar.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 3271de5844f8..7b47c7c49c08 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c@@ -669,7 +669,7 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev) return -EINVAL; } - *pdev = alloc_etherdev_mq(sizeof(*priv), num_tx_qs); + *pdev = alloc_etherdev_mqs(sizeof(*priv), num_tx_qs, num_rx_qs); dev = *pdev; if (NULL == dev) return -ENOMEM;@@ -679,10 +679,6 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev) priv->mode = mode; - priv->num_tx_queues = num_tx_qs; - netif_set_real_num_rx_queues(dev, num_rx_qs); - priv->num_rx_queues = num_rx_qs;
Please add to the commit message an explanation of why these two
assignments can be removed, because it is not obvious.
Andrew
---
pw-bot: cr