Re: [PATCH bpf v2 1/2] bpf: Reject TCP_NODELAY in TCP header option callbacks
From: Martin KaFai Lau <martin.lau@linux.dev>
Date: 2026-04-16 17:35:59
Also in:
bpf, linux-kselftest, lkml
On Thu, Apr 16, 2026 at 07:23:07PM +0800, KaFai Wan wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/core/filter.c b/net/core/filter.c index fcfcb72663ca..911ff04bca5a 100644 --- a/net/core/filter.c +++ b/net/core/filter.c@@ -5833,6 +5833,11 @@ BPF_CALL_5(bpf_sock_ops_setsockopt, struct bpf_sock_ops_kern *, bpf_sock, if (!is_locked_tcp_sock_ops(bpf_sock)) return -EOPNOTSUPP; + if ((bpf_sock->op == BPF_SOCK_OPS_HDR_OPT_LEN_CB || + bpf_sock->op == BPF_SOCK_OPS_WRITE_HDR_OPT_CB) && + IS_ENABLED(CONFIG_INET) && level == SOL_TCP && optname == TCP_NODELAY)
IS_ENABLED(CONFIG_INET) is unnecessary. pw-bot: cr
+ return -EOPNOTSUPP; + return _bpf_setsockopt(bpf_sock->sk, level, optname, optval, optlen); } -- 2.43.0