Sat, Feb 28, 2026 at 11:48:46PM +0100, kuba@kernel.org wrote:
On Wed, 25 Feb 2026 14:34:16 +0100 Jiri Pirko wrote:
quoted
+ if (attrs[DEVLINK_ATTR_INDEX]) {
+ index = nla_get_uint(attrs[DEVLINK_ATTR_INDEX]);
+ devlink = devlinks_xa_lookup_get(net, index);
+ if (!devlink)
+ return ERR_PTR(-ENODEV);
+ goto found;
+ }
+
if (!attrs[DEVLINK_ATTR_BUS_NAME] || !attrs[DEVLINK_ATTR_DEV_NAME])
return ERR_PTR(-EINVAL);
If both INDEX and BUS_NAME + DEV_NAME are provided we should check
that they point to the same device? Or reject user space passing both?
I implemented reject. I don't see much of value of allowing both. The
code that would do the checking is too much for this hypothetical case.