Thread (2 messages) 2 messages, 2 authors, 2026-03-30

Re: [PATCH net-next v1] net: macb: fix use of at91_default_usrio without CONFIG_OF

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-03-30 22:43:15
Also in: linux-devicetree, linux-riscv, lkml

On Mon, 30 Mar 2026 10:02:00 +0100 Conor Dooley wrote:
quoted hunk ↗ jump to hunk
@@ -5778,7 +5778,7 @@ static int macb_probe(struct platform_device *pdev)
 
 	macb_config = of_device_get_match_data(&pdev->dev);
 	if (!macb_config)
-		macb_config = &default_gem_config;
+		return -EINVAL;
 
AI reviewer says this will break macb_pci.c which registers a platform
device and will never have match data?

Feel free to post the v2 without the full 24h netdev wait if needed.
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help