On 30.3.2026 20:15, Mohsin Bashir wrote:

quoted

  		if (priv->crc_fwd_en) {
-			skb_trim(skb, len - ETH_FCS_LEN);
+			skb_trim(skb, skb->len - ETH_FCS_LEN);
  			len -= ETH_FCS_LEN;

Looks like 'len' update here is unnecessary since we are overwriting it 
later anyway?

Good catch, the len = skb->len assignment added in this patch makes len 
-= ETH_FCS_LEN dead code since skb_trim already removed the FCS. Will 
fix in v6.

Thanks
Nicolai

quoted

  		}
  +		/* Set up checksum offload */
+		if (dev->features & NETIF_F_RXCSUM) {
+			rx_csum = (__force __be16)(status->rx_csum & 0xffff);
+			if (rx_csum) {
+				skb->csum = (__force __wsum)ntohs(rx_csum);
+				skb->ip_summed = CHECKSUM_COMPLETE;
+			}
+		}
+
+		len = skb->len;