On Mon, Mar 30, 2026, at 10:49 AM, Jeff Layton wrote:

On Mon, 2026-03-30 at 10:22 -0400, Chuck Lever wrote:

quoted

quoted

+  -
+    name: svc-export-req
+    attributes:
+      -
+        name: seqno
+        type: u64
+      -
+        name: client
+        type: string
+      -
+        name: path
+        type: string

Is the svc-export-req attribute set used for anything?

No, good catch.

That's a holdover from an earlier version that had a separate attribute
set for the up and downcalls. It's not needed in the latest version.

It should be fine to remove it and regenerate the headers. The result
builds fine without it. I've pushed a fixed patch to the 'exportd-nl'
branch in my tree. You can fix it up or I can resend if you prefer.

Thanks for jumping on that. Let's wait to see if there are other review
comments.


-- 
Chuck Lever