Re: [PATCH 1/2] net: phy: microchip: add downshift tunable support for LAN88xx
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-03-30 13:01:18
Also in:
lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-03-30 13:01:18
Also in:
lkml
+ switch (val & LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_MASK) {
+ case LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_2:
+ *data = 2;
+ break;
+ case LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_3:
+ *data = 3;
+ break;
+ case LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_4:
+ *data = 4;
+ break;
+ case LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_5:
+ *data = 5;
+ break;
+ }+#define LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_2 (0 << 2) +#define LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_3 (1 << 2) +#define LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_4 (2 << 2) +#define LAN78XX_PHY_CTRL3_DOWNSHIFT_CTRL_5 (3 << 2)
It looks like you can replace the switch statement with a FIELD_GET() + 2.
Andrew
---
pw-bot: cr