Re: [PATCH net-next v3 1/3] dt-bindings: net: pse-pd: add poll-interval-ms property
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-03-30 07:10:03
Also in:
linux-devicetree, linux-leds, lkml
On Sun, Mar 29, 2026 at 05:31:22PM +0200, Carlo Szelinsky wrote:
Add the optional poll-interval-ms property for PSE controllers that use poll-based event detection instead of interrupts. Defaults to 500ms if not specified.
Why?
quoted hunk ↗ jump to hunk
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com> Signed-off-by: Carlo Szelinsky <redacted> --- .../devicetree/bindings/net/pse-pd/pse-controller.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml index cd09560e0aea..329d020f054c 100644 --- a/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml +++ b/Documentation/devicetree/bindings/net/pse-pd/pse-controller.yaml@@ -27,6 +27,14 @@ properties: subnode. This property is deprecated, please use pse-pis instead. enum: [0, 1] + poll-interval-ms:
We allow poll interval for input devices, because how sensitive buttons are or what capacitor is there charging/discharging is really a hardware property of the board. Why that would be true for PSE controller? Controller is specific, so any internal aspects of polling are already implied by compatible. You have entire commit msg to explain WHY you are doing this, not explain WHAT you did. We see what you did in the diff. Best regards, Krzysztof