RE: [EXTERNAL] Re: [PATCH net-next v2] net: mana: Set default number of queues to 16
From: Long Li <longli@microsoft.com>
Date: 2026-03-28 00:41:55
Also in:
linux-hyperv, linux-rdma, lkml
From: Long Li <longli@microsoft.com>
Date: 2026-03-28 00:41:55
Also in:
linux-hyperv, linux-rdma, lkml
On Fri, 27 Mar 2026 04:00:31 +0000 Long Li wrote:quoted
We considered netif_get_num_default_rss_queues() but chose a fixeddefault based on our performance testing. On Azure VMs, typicalquoted
workloads plateau at around 16 queues - adding more queues beyond thatdoesn't improve throughput but increases memory usage andquoted
interrupt overhead. netif_get_num_default_rss_queues() would return 32-64 on large VMs(64-128 vCPUs), which wastes resources without benefit.quoted
That said, I agree that completely ignoring the core-based heuristic isn'tideal for consistency. One option is to usequoted
netif_get_num_default_rss_queues() but clamp it to a maximum ofMANA_DEF_NUM_QUEUES (16), so small VMs still get enough queues andquoted
large VMs don't over-allocate. Something like: apc->num_queues = min(netif_get_num_default_rss_queues(),MANA_DEF_NUM_QUEUES);quoted
apc->num_queues = min(apc->num_queues, gc->max_num_queues); For reference, it seems mlx4 does something similar - it caps atDEF_RX_RINGS (16) regardless of core count. mlx4 is a bit ancient. And mlx5 does the wrong thing, which is why I'm so sensitive to this issue :(quoted
Do you want me to send a v2?Please send a follow up, let's leave this patch be and make an incremental change. Thanks!
I will send a follow-up patch. Thanks, Long