Re: [PATCH net-next v2 4/4] net: phy: Introduce Airoha AN8801/R Gigabit Ethernet PHY driver
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-03-27 01:43:40
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, lkml
On Thu, 26 Mar 2026 13:47:43 +0100 Andrew Lunn wrote:
quoted
+ if (phydev->link && prev_speed != phydev->speed) { + val = phydev->speed == SPEED_1000 ? + AN8801_BPBUS_LINK_MODE_1000 : 0; + + return an8801_buckpbus_reg_rmw(phydev, + AN8801_BPBUS_REG_LINK_MODE, + AN8801_BPBUS_LINK_MODE_1000, + val); + };This is unusual. What is it doing? Please add a comment.
Also - nit spurious ; after if () {}