On Tue, Mar 10, 2026 at 5:01 AM Jakub Kicinski [off-list ref] wrote:

On Mon, 9 Mar 2026 18:46:59 +0800 Qingfang Deng wrote:

quoted

quoted

Please add some selftests.

I haven't written a kselftest before. What tests should I include?

I think I can add a local ppp server and client over veth, and test
the connection with ping and iperf3.

We have tools/testing/selftests/drivers/net/gro.c and associated Python
test. (note I have ambiguous feelings about adding ppp cases to this
file vs creating a new test, adding Willem to CC maybe he has some
guidance)

He hasn't replied. What do you think?