Thread (3 messages) 3 messages, 3 authors, 2026-03-25

Re: [PATCH] net_sched: codel: fix stale state for empty flows in fq_codel

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-03-25 04:10:19
Also in: lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Mon, 23 Mar 2026 18:49:20 +0100 you wrote:
From: Jonas Köppeler <redacted>

When codel_dequeue() finds an empty queue, it resets vars->dropping
but does not reset vars->first_above_time.  The reference CoDel
algorithm (Nichols & Jacobson, ACM Queue 2012) resets both:

  dodeque_result codel_queue_t::dodeque(time_t now) {
      ...
      if (r.p == NULL) {
          first_above_time = 0;   // <-- Linux omits this
      }
      ...
  }

[...]
Here is the summary with links:
  - net_sched: codel: fix stale state for empty flows in fq_codel
    https://git.kernel.org/netdev/net/c/815980fe6dbb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help