Thread (14 messages) 14 messages, 3 authors, 2026-03-26
STALE89d
Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH net-next v1 2/7] net: hsr: replace fallthrough comments with fallthrough macro

From: <hidden>
Date: 2026-03-24 14:46:57
Also in: lkml
Subsystem: hsr network protocol, networking [general], the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

From: Luka Gejak <redacted>

Replace two instances of the legacy '/* Fall through */' comment with the
standardized 'fallthrough;' macro in hsr_get_node_status() and
hsr_get_node_list(). The kernel has standardized on the fallthrough macro
since the migration from comment-based annotations, which provides
compiler-level verification of intentional case fall-throughs.

Signed-off-by: Luka Gejak <redacted>
---
 net/hsr/hsr_netlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c
index db0b0af7a692..32c1b77cf84b 100644
--- a/net/hsr/hsr_netlink.c
+++ b/net/hsr/hsr_netlink.c
@@ -433,7 +433,7 @@ static int hsr_get_node_status(struct sk_buff *skb_in, struct genl_info *info)
 
 nla_put_failure:
 	kfree_skb(skb_out);
-	/* Fall through */
+	fallthrough;
 
 fail:
 	rcu_read_unlock();
@@ -524,7 +524,7 @@ static int hsr_get_node_list(struct sk_buff *skb_in, struct genl_info *info)
 
 nla_put_failure:
 	nlmsg_free(skb_out);
-	/* Fall through */
+	fallthrough;
 
 fail:
 	rcu_read_unlock();
-- 
2.53.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help