Thread (13 messages) 13 messages, 3 authors, 2026-03-25

Re: [PATCH v5 4/5] nfs: Refactor nfs_errorf macros and remove unused ones

From: Chuck Lever <hidden>
Date: 2026-03-21 16:38:34
Also in: linux-nfs, lkml

On 3/21/26 10:15 AM, Sean Chang wrote:
Refactor nfs_errorf() and nfs_ferrorf() to the standard do-while(0)
pattern for safer macro expansion and kernel style compliance.

Additionally, remove nfs_warnf() and nfs_fwarnf() as `git grep`
confirms they have no callers in the current tree. Furthermore,
these functions have remained unused since the introduction in
commit ce8866f0913f ("NFS: Attach supplementary error information
to fs_context.").

Reported-by: kernel test robot <redacted>
Closes: https://lore.kernel.org/oe-kbuild-all/202603110038.P6d14oxa-lkp@intel.com/ (local)
Reviewed-by: Andy Shevchenko <redacted>
Tested-by: Andy Shevchenko <redacted>
Signed-off-by: Sean Chang <redacted>
---
 fs/nfs/internal.h | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)
I need an Acked-by: from the NFS client maintainers on this one.


-- 
Chuck Lever
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help