Re: [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros

[PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros · Sean Chang <hidden> · 2026-03-19
[PATCH v3 1/3] nfsd/lockd: Remove redundant debug checks · Sean Chang <hidden> · 2026-03-19
[PATCH v3 2/3] svcrdma: remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards · Sean Chang <hidden> · 2026-03-19
[PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones · Sean Chang <hidden> · 2026-03-19
Re: [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones · Andy Shevchenko <hidden> · 2026-03-19
Re: [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones · Sean Chang <hidden> · 2026-03-19
Re: [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones · Andy Shevchenko <hidden> · 2026-03-19
Re: [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones · Sean Chang <hidden> · 2026-03-20
Re: [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros · Andy Shevchenko <hidden> · 2026-03-20
Re: [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros · Sean Chang <hidden> · 2026-03-20

From: Andy Shevchenko <hidden>
Date: 2026-03-20 12:08:38
Also in: linux-nfs, lkml

On Thu, Mar 19, 2026 at 10:18:43PM +0800, Sean Chang wrote:

This series cleans up redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards 
across sunrpc, nfsd, and lockd, as these checks are already handled 
within the dprintk macros.

Additionally, it refactors the nfs_errorf() macros into a safer 
do-while(0) pattern and removes unused nfs_warnf() macros to improve 
code maintainability.

Shall we also revert the commit ebae102897e7 ("nfsd: Mark variable
__maybe_unused to avoid W=1 build break") as it seems related to
dprintk() issues?


-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help