Re: [PATCH v7 4/5] nvme-tcp: Support KeyUpdate
From: Christoph Hellwig <hch@lst.de>
Date: 2026-03-20 07:51:24
Also in:
linux-doc, linux-nfs, linux-nvme, lkml
From: Christoph Hellwig <hch@lst.de>
Date: 2026-03-20 07:51:24
Also in:
linux-doc, linux-nfs, linux-nvme, lkml
On Wed, Mar 04, 2026 at 09:37:22PM +1000, Alistair Francis wrote:
quoted
I think a simple 'if' condition would be sufficient here, or do you have handling of other TLS record types queued somewhere? And we should log unhandled TLS records.I like this approach as it makes it really easy to handle more types in the future. I don't have any more record types queued anywhere so I can change it to an if statement.
Agreed. OTOH having more than a handful of lines in switches like this is a always a bad idea, so factoring this out into a type-specific helper would be much preferred.