Re: [PATCH net-next 2/2] r8152: add helper functions for PHY OCP registers
From: kernel test robot <hidden>
Date: 2026-03-19 20:48:15
Also in:
linux-usb, lkml, oe-kbuild-all
Hi hsuck, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/hsuck/r8152-add-helper-functions-for-PLA-USB-OCP-registers/20260318-232634 base: net-next/main patch link: https://lore.kernel.org/r/20260318123313.2313-446-nic_swsd%40realtek.com patch subject: [PATCH net-next 2/2] r8152: add helper functions for PHY OCP registers config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260320/202603200420.7kabrAGG-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260320/202603200420.7kabrAGG-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202603200420.7kabrAGG-lkp@intel.com/ (local) All warnings (new ones prefixed by >>): drivers/net/usb/r8152.c: In function 'r8153_init':
quoted
drivers/net/usb/r8152.c:6864:13: warning: variable 'data' set but not used [-Wunused-but-set-variable]
6864 | u16 data;
| ^~~~
drivers/net/usb/r8152.c: In function 'r8153b_init':
drivers/net/usb/r8152.c:6983:13: warning: variable 'data' set but not used [-Wunused-but-set-variable]
6983 | u16 data;
| ^~~~
drivers/net/usb/r8152.c: In function 'r8153c_init':
drivers/net/usb/r8152.c:7054:13: warning: variable 'data' set but not used [-Wunused-but-set-variable]
7054 | u16 data;
| ^~~~
vim +/data +6864 drivers/net/usb/r8152.c
195aae321c829d Hayes Wang 2021-04-16 6861
195aae321c829d Hayes Wang 2021-04-16 6862 static void r8153_init(struct r8152 *tp)
195aae321c829d Hayes Wang 2021-04-16 6863 {
195aae321c829d Hayes Wang 2021-04-16 @6864 u16 data;
195aae321c829d Hayes Wang 2021-04-16 6865 int i;
195aae321c829d Hayes Wang 2021-04-16 6866
715f67f33af45c Douglas Anderson 2023-10-20 6867 if (test_bit(RTL8152_INACCESSIBLE, &tp->flags))
195aae321c829d Hayes Wang 2021-04-16 6868 return;
195aae321c829d Hayes Wang 2021-04-16 6869
195aae321c829d Hayes Wang 2021-04-16 6870 r8153_u1u2en(tp, false);
195aae321c829d Hayes Wang 2021-04-16 6871
195aae321c829d Hayes Wang 2021-04-16 6872 for (i = 0; i < 500; i++) {
195aae321c829d Hayes Wang 2021-04-16 6873 if (ocp_read_word(tp, MCU_TYPE_PLA, PLA_BOOT_CTRL) &
195aae321c829d Hayes Wang 2021-04-16 6874 AUTOLOAD_DONE)
195aae321c829d Hayes Wang 2021-04-16 6875 break;
195aae321c829d Hayes Wang 2021-04-16 6876
195aae321c829d Hayes Wang 2021-04-16 6877 msleep(20);
715f67f33af45c Douglas Anderson 2023-10-20 6878 if (test_bit(RTL8152_INACCESSIBLE, &tp->flags))
195aae321c829d Hayes Wang 2021-04-16 6879 break;
195aae321c829d Hayes Wang 2021-04-16 6880 }
195aae321c829d Hayes Wang 2021-04-16 6881
195aae321c829d Hayes Wang 2021-04-16 6882 data = r8153_phy_status(tp, 0);
195aae321c829d Hayes Wang 2021-04-16 6883
195aae321c829d Hayes Wang 2021-04-16 6884 if (tp->version == RTL_VER_03 || tp->version == RTL_VER_04 ||
195aae321c829d Hayes Wang 2021-04-16 6885 tp->version == RTL_VER_05)
195aae321c829d Hayes Wang 2021-04-16 6886 ocp_reg_write(tp, OCP_ADC_CFG, CKADSEL_L | ADC_EN | EN_EMI_L);
195aae321c829d Hayes Wang 2021-04-16 6887
b520efeb0a4573 hsuck 2026-03-18 6888 r8152_mdio_test_and_clr_bit(tp, MII_BMCR, BMCR_PDOWN);
195aae321c829d Hayes Wang 2021-04-16 6889
195aae321c829d Hayes Wang 2021-04-16 6890 data = r8153_phy_status(tp, PHY_STAT_LAN_ON);
195aae321c829d Hayes Wang 2021-04-16 6891
195aae321c829d Hayes Wang 2021-04-16 6892 r8153_u2p3en(tp, false);
195aae321c829d Hayes Wang 2021-04-16 6893
195aae321c829d Hayes Wang 2021-04-16 6894 if (tp->version == RTL_VER_04) {
ce600d52ace5a4 hsuck 2026-03-18 6895 ocp_word_w0w1(tp, MCU_TYPE_USB, USB_SSPHYLINK2,
ce600d52ace5a4 hsuck 2026-03-18 6896 pwd_dn_scale_mask, pwd_dn_scale(96));
ce600d52ace5a4 hsuck 2026-03-18 6897
ce600d52ace5a4 hsuck 2026-03-18 6898 ocp_byte_set_bits(tp, MCU_TYPE_USB, USB_USB2PHY,
ce600d52ace5a4 hsuck 2026-03-18 6899 USB2PHY_L1 | USB2PHY_SUSPEND);
195aae321c829d Hayes Wang 2021-04-16 6900 } else if (tp->version == RTL_VER_05) {
ce600d52ace5a4 hsuck 2026-03-18 6901 ocp_byte_clr_bits(tp, MCU_TYPE_PLA, PLA_DMY_REG0, ECM_ALDPS);
195aae321c829d Hayes Wang 2021-04-16 6902
195aae321c829d Hayes Wang 2021-04-16 6903 if (ocp_read_word(tp, MCU_TYPE_USB, USB_BURST_SIZE) == 0)
ce600d52ace5a4 hsuck 2026-03-18 6904 ocp_byte_clr_bits(tp, MCU_TYPE_USB, USB_CSR_DUMMY1,
ce600d52ace5a4 hsuck 2026-03-18 6905 DYNAMIC_BURST);
195aae321c829d Hayes Wang 2021-04-16 6906 else
ce600d52ace5a4 hsuck 2026-03-18 6907 ocp_byte_set_bits(tp, MCU_TYPE_USB, USB_CSR_DUMMY1,
ce600d52ace5a4 hsuck 2026-03-18 6908 DYNAMIC_BURST);
195aae321c829d Hayes Wang 2021-04-16 6909 } else if (tp->version == RTL_VER_06) {
195aae321c829d Hayes Wang 2021-04-16 6910 if (ocp_read_word(tp, MCU_TYPE_USB, USB_BURST_SIZE) == 0)
ce600d52ace5a4 hsuck 2026-03-18 6911 ocp_byte_clr_bits(tp, MCU_TYPE_USB, USB_CSR_DUMMY1,
ce600d52ace5a4 hsuck 2026-03-18 6912 DYNAMIC_BURST);
195aae321c829d Hayes Wang 2021-04-16 6913 else
ce600d52ace5a4 hsuck 2026-03-18 6914 ocp_byte_set_bits(tp, MCU_TYPE_USB, USB_CSR_DUMMY1,
ce600d52ace5a4 hsuck 2026-03-18 6915 DYNAMIC_BURST);
195aae321c829d Hayes Wang 2021-04-16 6916
195aae321c829d Hayes Wang 2021-04-16 6917 r8153_queue_wake(tp, false);
195aae321c829d Hayes Wang 2021-04-16 6918
195aae321c829d Hayes Wang 2021-04-16 6919 if (rtl8152_get_speed(tp) & LINK_STATUS)
ce600d52ace5a4 hsuck 2026-03-18 6920 ocp_word_set_bits(tp, MCU_TYPE_PLA, PLA_EXTRA_STATUS,
ce600d52ace5a4 hsuck 2026-03-18 6921 CUR_LINK_OK | POLL_LINK_CHG);
195aae321c829d Hayes Wang 2021-04-16 6922 else
ce600d52ace5a4 hsuck 2026-03-18 6923 ocp_word_w0w1(tp, MCU_TYPE_PLA, PLA_EXTRA_STATUS,
ce600d52ace5a4 hsuck 2026-03-18 6924 CUR_LINK_OK, POLL_LINK_CHG);
195aae321c829d Hayes Wang 2021-04-16 6925 }
195aae321c829d Hayes Wang 2021-04-16 6926
ce600d52ace5a4 hsuck 2026-03-18 6927 ocp_byte_set_bits(tp, MCU_TYPE_USB, USB_CSR_DUMMY2, EP4_FULL_FC);
195aae321c829d Hayes Wang 2021-04-16 6928
ce600d52ace5a4 hsuck 2026-03-18 6929 ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_WDT11_CTRL, TIMER11_EN);
195aae321c829d Hayes Wang 2021-04-16 6930
ce600d52ace5a4 hsuck 2026-03-18 6931 ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_LED_FEATURE, LED_MODE_MASK);
195aae321c829d Hayes Wang 2021-04-16 6932
195aae321c829d Hayes Wang 2021-04-16 6933 if (tp->version == RTL_VER_04 && tp->udev->speed < USB_SPEED_SUPER)
ce600d52ace5a4 hsuck 2026-03-18 6934 ocp_byte_set_bits(tp, MCU_TYPE_USB, USB_LPM_CTRL,
ce600d52ace5a4 hsuck 2026-03-18 6935 FIFO_EMPTY_1FB | ROK_EXIT_LPM |
ce600d52ace5a4 hsuck 2026-03-18 6936 LPM_TIMER_500MS);
195aae321c829d Hayes Wang 2021-04-16 6937 else
ce600d52ace5a4 hsuck 2026-03-18 6938 ocp_byte_set_bits(tp, MCU_TYPE_USB, USB_LPM_CTRL,
ce600d52ace5a4 hsuck 2026-03-18 6939 FIFO_EMPTY_1FB | ROK_EXIT_LPM |
ce600d52ace5a4 hsuck 2026-03-18 6940 LPM_TIMER_500US);
195aae321c829d Hayes Wang 2021-04-16 6941
ce600d52ace5a4 hsuck 2026-03-18 6942 ocp_word_w0w1(tp, MCU_TYPE_USB, USB_AFE_CTRL2, SEN_VAL_MASK,
ce600d52ace5a4 hsuck 2026-03-18 6943 SEN_VAL_NORMAL | SEL_RXIDLE);
195aae321c829d Hayes Wang 2021-04-16 6944
195aae321c829d Hayes Wang 2021-04-16 6945 ocp_write_word(tp, MCU_TYPE_USB, USB_CONNECT_TIMER, 0x0001);
195aae321c829d Hayes Wang 2021-04-16 6946
195aae321c829d Hayes Wang 2021-04-16 6947 r8153_power_cut_en(tp, false);
195aae321c829d Hayes Wang 2021-04-16 6948 rtl_runtime_suspend_enable(tp, false);
195aae321c829d Hayes Wang 2021-04-16 6949 r8153_mac_clk_speed_down(tp, false);
195aae321c829d Hayes Wang 2021-04-16 6950 r8153_u1u2en(tp, true);
195aae321c829d Hayes Wang 2021-04-16 6951 usb_enable_lpm(tp->udev);
195aae321c829d Hayes Wang 2021-04-16 6952
ce600d52ace5a4 hsuck 2026-03-18 6953 ocp_byte_set_bits(tp, MCU_TYPE_PLA, PLA_CONFIG6, LANWAKE_CLR_EN);
195aae321c829d Hayes Wang 2021-04-16 6954
ce600d52ace5a4 hsuck 2026-03-18 6955 ocp_byte_clr_bits(tp, MCU_TYPE_PLA, PLA_LWAKE_CTRL_REG, LANWAKE_PIN);
195aae321c829d Hayes Wang 2021-04-16 6956
195aae321c829d Hayes Wang 2021-04-16 6957 /* rx aggregation */
ce600d52ace5a4 hsuck 2026-03-18 6958 ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_USB_CTRL,
ce600d52ace5a4 hsuck 2026-03-18 6959 RX_AGG_DISABLE | RX_ZERO_EN);
195aae321c829d Hayes Wang 2021-04-16 6960
ce600d52ace5a4 hsuck 2026-03-18 6961 if (tp->dell_tb_rx_agg_bug)
ce600d52ace5a4 hsuck 2026-03-18 6962 ocp_word_set_bits(tp, MCU_TYPE_USB, USB_USB_CTRL,
ce600d52ace5a4 hsuck 2026-03-18 6963 RX_AGG_DISABLE);
195aae321c829d Hayes Wang 2021-04-16 6964
195aae321c829d Hayes Wang 2021-04-16 6965 rtl_tally_reset(tp);
195aae321c829d Hayes Wang 2021-04-16 6966
195aae321c829d Hayes Wang 2021-04-16 6967 switch (tp->udev->speed) {
195aae321c829d Hayes Wang 2021-04-16 6968 case USB_SPEED_SUPER:
195aae321c829d Hayes Wang 2021-04-16 6969 case USB_SPEED_SUPER_PLUS:
195aae321c829d Hayes Wang 2021-04-16 6970 tp->coalesce = COALESCE_SUPER;
195aae321c829d Hayes Wang 2021-04-16 6971 break;
195aae321c829d Hayes Wang 2021-04-16 6972 case USB_SPEED_HIGH:
195aae321c829d Hayes Wang 2021-04-16 6973 tp->coalesce = COALESCE_HIGH;
195aae321c829d Hayes Wang 2021-04-16 6974 break;
195aae321c829d Hayes Wang 2021-04-16 6975 default:
195aae321c829d Hayes Wang 2021-04-16 6976 tp->coalesce = COALESCE_SLOW;
195aae321c829d Hayes Wang 2021-04-16 6977 break;
195aae321c829d Hayes Wang 2021-04-16 6978 }
195aae321c829d Hayes Wang 2021-04-16 6979 }
195aae321c829d Hayes Wang 2021-04-16 6980
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki