Re: [PATCH net-next] net/mlx5e: Add hds-thresh query support via ethtool
From: Joe Damato <hidden>
Date: 2026-03-18 20:11:12
Also in:
linux-rdma, lkml
On Tue, Mar 17, 2026 at 12:49:34PM +0200, Tariq Toukan wrote:
quoted hunk ↗ jump to hunk
From: Nimrod Oren <redacted> Add support for reporting HDS (Header-Data Split) threshold via ethtool. When applicable, mlx5 hardware splits packets of all sizes with no configurable threshold, so report both hds-thresh and hds-thresh-max as 0 (i.e. always split regardless of size). Signed-off-by: Nimrod Oren <redacted> Reviewed-by: Carolina Jubran <redacted> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com> Signed-off-by: Tariq Toukan <tariqt@nvidia.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index 4a8dc85d5924..bb61e2179078 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c@@ -371,6 +371,9 @@ void mlx5e_ethtool_get_ringparam(struct mlx5e_priv *priv, param->tx_max_pending = 1 << MLX5E_PARAMS_MAXIMUM_LOG_SQ_SIZE; param->rx_pending = 1 << priv->channels.params.log_rq_mtu_frames; param->tx_pending = 1 << priv->channels.params.log_sq_size; + + kernel_param->hds_thresh = 0;
I think this is populated by the core before the call to get_ringparam and it looks like it is defaulted to 0, so I think this assignment is unnecessary. But everything else seems fine, so: Reviewed-by: Joe Damato <redacted>