Re: [PATCH net-next 5/6] selftests: drv-net: add netkit devmem RX test

From
Bobby Eshleman <hidden>
Date
2026-03-18 16:21:38
Also in
bpf, linux-kselftest, lkml
Reply to
Stanislav Fomichev, 2026-03-18
On Wed, Mar 18, 2026 at 07:59:57AM -0700, Stanislav Fomichev wrote:
On 03/17, Bobby Eshleman wrote:
quoted
On Tue, Mar 17, 2026 at 05:08:20PM -0700, Stanislav Fomichev wrote:
quoted
On 03/16, Bobby Eshleman wrote:
quoted
From: Bobby Eshleman <bobbyeshleman@meta.com>

Add tests for devmem RX over a netkit device with a leased queue. This
is the same as the other devmem RX test except for ncdevmem executes in
a namespace, binds to a netkit, and skips the ethtool NIC configuration
steps (relying on the test runner for that setup).

The RX path is setup as the following:

 RX Path
 -------

 Remote            Physical NIC          Netkit Host        Netkit Guest (netns)
   |                    |                     |                    |
   |--- TCP send ------>|                     |                    |
                        |-------------------->|                    |
                      dmabuf                  |--- BPF redirect -->|
Is it too messy to parametrize the existing test to run both with and
without the namespaces? Feels like should be somewhat doable in python?
IIUC, we could have main() do something like:

for env [NetDrvContEnv, NetDrvEpEnv]:
    with env as cfg:
        [...]
        ksft_run(tests, args=(cfg,))


And then the tests could call helpers that check cfg.netns to use the
nk_{guest,host}_ip6 addresses when true, otherwise use the regular
addresses?

It should be doable if I'm following your drift.
Yeah, yeah, this plus some small changes here and there (to pass your
new -n in the netns mode for example).
Sounds good, I'll give it a look.
Thread (13 messages) 13 messages, 3 authors, last reply 2026-03-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help