RE: [Intel-wired-lan] [PATCH net-next v2 05/13] fbnic: convert to ndo_set_rx_mode_async
From: Loktionov, Aleksandr <hidden>
Date: 2026-03-18 15:43:39
Also in:
intel-wired-lan, linux-doc, linux-kselftest, linux-rdma, linux-wireless, lkml
quoted hunk ↗ jump to hunk
-----Original Message----- From: Intel-wired-lan <redacted> On Behalf Of Stanislav Fomichev Sent: Wednesday, March 18, 2026 4:03 PM To: netdev@vger.kernel.org Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; horms@kernel.org; corbet@lwn.net; skhan@linuxfoundation.org; andrew+netdev@lunn.ch; michael.chan@broadcom.com; pavan.chebbi@broadcom.com; Nguyen, Anthony L [off-list ref]; Kitszel, Przemyslaw [off-list ref]; saeedm@nvidia.com; tariqt@nvidia.com; mbloch@nvidia.com; alexanderduyck@fb.com; kernel-team@meta.com; johannes@sipsolutions.net; sd@queasysnail.net; jianbol@nvidia.com; dtatulea@nvidia.com; sdf@fomichev.me; mohsin.bashr@gmail.com; Keller, Jacob E [off-list ref]; willemb@google.com; skhawaja@google.com; bestswngs@gmail.com; linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- rdma@vger.kernel.org; linux-wireless@vger.kernel.org; linux- kselftest@vger.kernel.org; leon@kernel.org Subject: [Intel-wired-lan] [PATCH net-next v2 05/13] fbnic: convert to ndo_set_rx_mode_async Convert fbnic from ndo_set_rx_mode to ndo_set_rx_mode_async. The driver's __fbnic_set_rx_mode() now takes explicit uc/mc list parameters and uses __hw_addr_sync_dev() on the snapshots instead of __dev_uc_sync/__dev_mc_sync on the netdev directly. Update callers in fbnic_up, fbnic_fw_config_after_crash, fbnic_bmc_rpc_check and fbnic_set_mac to pass the real address lists calling __fbnic_set_rx_mode outside the async work path. Cc: Alexander Duyck <alexanderduyck@fb.com> Cc: kernel-team@meta.com Signed-off-by: Stanislav Fomichev <sdf@fomichev.me> --- .../net/ethernet/meta/fbnic/fbnic_netdev.c | 20 ++++++++++++------ - .../net/ethernet/meta/fbnic/fbnic_netdev.h | 4 +++- drivers/net/ethernet/meta/fbnic/fbnic_pci.c | 4 ++-- drivers/net/ethernet/meta/fbnic/fbnic_rpc.c | 2 +- 4 files changed, 19 insertions(+), 11 deletions(-)diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.cb/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c index b4b396ca9bce..c406a3b56b37 100644--- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c@@ -183,7 +183,9 @@ static int fbnic_mc_unsync(struct net_device*netdev, const unsigned char *addr) return ret; }
...
quoted
mc);fbd->fw_cap.need_bmc_tcam_reinit = false; } -- 2.53.0
Reviewed-by: Aleksandr Loktionov <redacted>