Re: [PATCH net-next 1/2] selftests/vsock: fix vmtest.sh for read-only nested VM runners
From: Paolo Abeni <pabeni@redhat.com>
Date: 2026-03-17 14:46:42
Also in:
linux-kselftest, lkml, virtualization
On 3/14/26 1:00 AM, Bobby Eshleman wrote:
quoted hunk ↗ jump to hunk
tools/testing/selftests/vsock/vmtest.sh | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh index 86e338886b33..c2cfcdf05d99 100755 --- a/tools/testing/selftests/vsock/vmtest.sh +++ b/tools/testing/selftests/vsock/vmtest.sh@@ -42,6 +42,8 @@ readonly KERNEL_CMDLINE="\ virtme.ssh virtme_ssh_channel=tcp virtme_ssh_user=$USER \ " readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log) +readonly TEST_HOME=$(mktemp -d /tmp/vmtest_home_XXXX)
shellcheck complains:
In vmtest.sh line 45:
readonly TEST_HOME=$(mktemp -d /tmp/vmtest_home_XXXX)
^-------^ SC2155 (warning): Declare and assign separately to
avoid masking return values.
quoted hunk ↗ jump to hunk
@@ -451,11 +464,14 @@ vm_start() { --run \ ${kernel_opt} \ ${verbose_opt} \ + --rwdir=/root=${TEST_HOME} \
And here, too:
In vmtest.sh line 467:
--rwdir=/root=${TEST_HOME} \
^----------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
Did you mean:
--rwdir=/root="${TEST_HOME}" \
The first occurrence could possibly be explicitly silenced explicitly,
but it's probably better to really address the latter.
/P