Thread (20 messages) 20 messages, 3 authors, 2026-04-10

Re: [PATCH net-next 6/9] r8152: Add support for chip version RTL_VER_16

From: Birger Koblitz <hidden>
Date: 2026-03-17 04:36:08
Also in: linux-usb, lkml

Hi Jakub,

thanks for reviewing!
On 17/03/2026 1:50 am, Jakub Kicinski wrote:
On Sat, 14 Mar 2026 10:31:42 +0100 Birger Koblitz wrote:
quoted
The RTL8157 uses RTL_VER_16. Add support for this version in all
remaining configuration functions for power management and RX/TX
configuration.
../drivers/net/usb/r8152.c:1744:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
  1744 |         if (i == 10)
       |             ^~~~~~~
../drivers/net/usb/r8152.c:1747:9: note: uninitialized use occurs here
  1747 |         return ret;
       |                ^~~
../drivers/net/usb/r8152.c:1744:2: note: remove the 'if' if its condition is always true
  1744 |         if (i == 10)
       |         ^~~~~~~~~~~~
  1745 |                 ret = -ETIMEDOUT;
../drivers/net/usb/r8152.c:1734:12: note: initialize the variable 'ret' to silence this warning
  1734 |         int i, ret;
       |                   ^
       |                    = 0
Will be fixed, of course, in v2. I need to figure out why I did not get 
these compiler warnings.

Birger
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help