Re: [PATCH net-next v10 1/4] dt-bindings: net: Add support for Spacemit K3 dwmac
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-03-17 03:21:50
Also in:
linux-arm-kernel, linux-devicetree, linux-riscv, lkml, spacemit
On Mon, 16 Mar 2026 09:00:37 +0800 Inochi Amaoto wrote:
The GMAC IP on Spacemit K3 is almost a standard Synopsys DesignWare MAC (version 5.40a) with some extra clock. Add necessary compatible string for this device.
In the previous version the AI reviewer complained that we're not adding the new entry to the select at the top of the file. Other compatibles appear in 3 places in Documentation/devicetree/bindings/net/snps,dwmac.yaml Also I asked whether we can drop the "default m" Did you disagree with those comments or did you miss them? stmmac is a strange beast I don't really know what's going on in the binding, so just double checking this is intentional..