On Tue, Mar 10, 2026 at 01:09:08AM +0100, Daniel Lezcano wrote:

On 3/10/26 00:50, Jeff Johnson wrote:

quoted

On 3/9/2026 4:03 PM, Daniel Lezcano wrote:

quoted

The different subsystems implementing the QMI service protocol are
using their own definition of the service id. It is not a problem but
it results on having those duplicated with different names but the
same value and without consistency in their name.

It makes more sense to unify their names and move the definitions in

[ ... ]

quoted

prefix for wireless drivers is simply wifi: <driver>:
so s/net: drivers: wireless:/wifi:/

Noted, thanks

quoted

quoted

   remoteproc: qcom: Use the unified QMI service ID instead of defining
     it locally
   slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of
     defining it locally
   soc: qcom: pdr: Use the unified QMI service ID instead of defining it
     locally
   ALSA: usb-audio: qcom: Use the unified QMI service ID instead of
     defining it locally
   samples: qmi: Use the unified QMI service ID instead of defining it
     locally

  drivers/net/ipa/ipa_qmi.c                      |  6 ++----
  drivers/net/wireless/ath/ath10k/qmi.c          |  2 +-
  drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h |  1 -
  drivers/net/wireless/ath/ath11k/qmi.c          |  2 +-
  drivers/net/wireless/ath/ath11k/qmi.h          |  1 -
  drivers/net/wireless/ath/ath12k/qmi.c          |  2 +-
  drivers/net/wireless/ath/ath12k/qmi.h          |  1 -
  drivers/remoteproc/qcom_sysmon.c               |  2 +-
  drivers/slimbus/qcom-ngd-ctrl.c                |  5 ++---
  drivers/soc/qcom/pdr_interface.c               |  4 ++--
  drivers/soc/qcom/pdr_internal.h                |  3 ---
  drivers/soc/qcom/qcom_pd_mapper.c              |  2 +-
  include/linux/soc/qcom/qmi.h                   | 12 ++++++++++++
  samples/qmi/qmi_sample_client.c                |  2 +-
  sound/usb/qcom/qc_audio_offload.c              |  2 +-
  sound/usb/qcom/usb_audio_qmi_v01.h             |  1 -

You are touching a lot of subsystems with a single series.
How do you plan on having these land?
Do you have a maintainer who will take all of these through their tree?

Yes I thought Bjorn or Konrad would take them with the acked-by from the
different subsystems

As we haven't received any such acks, I pulled patch 1 into an immutable
branch and pushed it here:

  https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com

Other maintainers can use this to pull respective changes, or you can
repost the individual patches with this (or follow up once it's in
-rc1).

Regards,
Bjorn