Thread (20 messages) 20 messages, 2 authors, 2026-03-13

Re: 回复:[PATCH v7 net-next 03/11] net/nebula-matrix: add chip related definitions

From: Paolo Abeni <pabeni@redhat.com>
Date: 2026-03-13 09:36:30
Also in: linux-doc, lkml

On 3/13/26 9:05 AM, Illusion Wang wrote:
I am so sorry, Last time I missed a 'not'

These data are used to configure P4-related registers. The driver’s functionality

depends heavily on these register settings. They will be declared as const.

But they can be not marked __initdata. Because it will be called by pci_driver.probe.

They also should not be moved into firmware files, as the software functionality

is tightly coupled with these configurations. If they were moved to firmware,

users could easily end up with mismatched versions of the firmware and the kernel

driver module, leading to functional inconsistencies or system malfunctions.
Please add the above explanation somewhere in the commit message or in a
code comment.

I appreciated you switched to plaintext for ML messages; please
additionally try to properly quote the relevant part of the message you
are replaying to: it will help following the conversation.

Thanks,

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help