Thread (8 messages) 8 messages, 2 authors, 2026-03-13

Re: [PATCH net-next v9 3/4] net: stmmac: Add glue layer for Spacemit K3 SoC

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-03-13 02:38:04
Also in: linux-arm-kernel, linux-devicetree, linux-riscv, lkml, spacemit

Some nit picks only to be addressed in case the AI complaint on patch 1
is legit..

On Thu, 12 Mar 2026 09:22:25 +0800 Inochi Amaoto wrote:
+config DWMAC_SPACEMIT
+	tristate "Spacemit dwmac support"
+	depends on OF && (ARCH_SPACEMIT || COMPILE_TEST)
+	select MFD_SYSCON
+	default m if ARCH_SPACEMIT
I know other STMMAC sub-drivers do it but isn't the defconfig for 
the platform the right place to add this sort of default?
+	apmu = syscon_regmap_lookup_by_phandle_args(pdev->dev.of_node,
+						    "spacemit,apmu", 2,
+						    offset);
+	if (IS_ERR(apmu))
+		return dev_err_probe(dev, PTR_ERR(apmu),
+				"Failed to get apmu regmap\n");
looks mis-aligned 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help