Re: [PATCH net-next V2 1/5] net/mlx5e: Report hw_gso_packets and hw_gso_bytes netdev stats
From: Gal Pressman <hidden>
Date: 2026-03-12 09:49:34
Also in:
linux-rdma, lkml
Thanks for the review on the series Jakub! On 11/03/2026 5:12, Jakub Kicinski wrote:
On Mon, 9 Mar 2026 11:55:15 +0200 Tariq Toukan wrote:quoted
From: Gal Pressman <redacted> Report hardware GSO statistics via the netdev queue stats API by mapping the existing TSO counters to hw_gso_packets and hw_gso_bytes fields.The docs on our stats are based on the virtio spec: https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 which is not very detailed, but to me "bytes of TSO packets" is a sum of skb->len of those packets. And mlx5 seems to only be counting payloads??
TBH, I'm surprised this is our behavior, not intuitive at all.. I'm inclined to just change it to account for the headers, hope it won't break anything.