Thread (8 messages) 8 messages, 3 authors, 2026-03-12

Re: [PATCH v8 1/5] net: stmmac: Use helper macro for loop over queue-based arrays

From: Jan Petrous <jan.petrous@oss.nxp.com>
Date: 2026-03-12 07:50:17
Also in: imx, linux-arm-kernel, linux-devicetree, lkml

On Wed, Mar 11, 2026 at 08:37:07PM -0700, Jakub Kicinski wrote:
On Mon, 09 Mar 2026 18:55:20 +0100 Jan Petrous via B4 Relay wrote:
quoted
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
This is macro is neither shorter nor more readable.
I really don't see any benefit here..
TBH me neither. Or, I see only "descriptive" benefit, what, of course,
is nothing must-to-have.

I will prepare v11 without this.

Thanks.
/Jan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help