Thread (33 messages) 33 messages, 4 authors, 2026-03-09

Re: [PATCH v2 phy-next 24/24] MAINTAINERS: add regexes for linux-phy

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2026-03-08 20:56:32
Also in: dri-devel, linux-arm-kernel, linux-arm-msm, linux-can, linux-gpio, linux-ide, linux-media, linux-pci, linux-phy, linux-renesas-soc, linux-riscv, linux-rockchip, linux-samsung-soc, linux-sunxi, linux-tegra, linux-usb, lkml, spacemit

On Sun, Mar 08, 2026 at 12:25:32PM -0700, Joe Perches wrote:
On Sun, 2026-03-08 at 21:10 +0200, Vladimir Oltean wrote:
quoted
On Sun, Mar 08, 2026 at 11:40:44AM -0700, Joe Perches wrote:
quoted
Perhaps if matching only the include uses:
(/ is escaped because get_maintainer is stupid)
something like:

K:	include\s*\<linux\/phy\/phy(?:-common-props|-provider)?\.h\>
quoted
Why is get_maintainer stupid?
The get_maintainer code used to match keywords is

	    foreach my $line (keys %keyword_hash) {
		if ($text =~ m/$keyword_hash{$line}/x) {

so it seems the first / in the K: <foo> regex would terminate
the match.

It might have been better to use a different delimiter.
Maybe:

		if ($text =~ m{$keyword_hash{$line}}/x
So why does it match in my example?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help