On 06/03/2026 22:03, Jakub Kicinski wrote:

External email: Use caution opening links or attachments


On Fri, 6 Mar 2026 13:13:26 +0100 Jiri Pirko wrote:

quoted

Thu, Mar 05, 2026 at 03:37:29PM +0100, kuba@kernel.org wrote:

quoted

On Thu, 5 Mar 2026 08:56:42 +0100 Jiri Pirko wrote:

quoted

Or, alternatively, we can have per-object dumps as we have for all
objects and command right now and leave things simple and
straightforward? I mean, I don't really see a benefit of a single dump
for more objects :/

What do you mean by straightforward, exactly?

User will most likely want to see all resources of a device in a single
dump / command.

Hmm. We actually already have this for region and health reporter dumps.
Only for params we have that separate.
So let's do it for resource too.

That's not a good argument, as I said in my first response to the
thread:

   I worry we are mechanically following the design of other commands.

https://lore.kernel.org/all/20260302192640.49af074f@kernel.org/ (local)

Hi,

Do you mean that we will register resources per port, but not show with 
new devlink port resource show.
Instead, the current devlink resource show dev command will also display 
the ports of that device?

For example:

$ devlink resource show pci/0000:03:00.0
   pci/0000:03:00.0:
     name local_max_SFs size 40 unit entry
   pci/0000:03:00.0/196608:
      name max_SFs size 20 unit entry
   pci/0000:03:00.0/196609:
      name max_SFs size 20 unit entry

Or should we keep the current behavior where devlink resource show dev 
displays only device-level resources, and only the full dump shows both 
devices and their ports?

For example:

$ devlink resource show
   pci/0000:03:00.0:
     name local_max_SFs size 40 unit entry
   pci/0000:03:00.0/196608:
      name max_SFs size 20 unit entry
   pci/0000:03:00.0/196609:
      name max_SFs size 20 unit entry
   pci/0000:03:00.1:
     name local_max_SFs size 40 unit entry
   pci/0000:03:00.1/196608:
      name max_SFs size 20 unit entry
   pci/0000:03:00.1/196609:
      name max_SFs size 20 unit entry

Want to confirm which behavior you meant.

Thanks.