Re: [PATCH] net: xgbe: use device_get_mac_addr

From
Jakub Kicinski <kuba@kernel.org>
Date
2026-03-07 00:59:45
Also in
lkml
Reply to
Rosen Penev, 2026-03-04
On Tue,  3 Mar 2026 20:22:40 -0800 Rosen Penev wrote:
quoted hunk ↗ jump to hunk
-	ret = device_property_read_u8_array(dev, XGBE_MAC_ADDR_PROPERTY,
-					    pdata->mac_addr,
-					    sizeof(pdata->mac_addr));
-	if (ret || !is_valid_ether_addr(pdata->mac_addr)) {
+	ret = device_get_mac_address(dev, pdata->mac_addr);
+	if (ret) {
 		dev_err(dev, "invalid %s property\n", XGBE_MAC_ADDR_PROPERTY);
Feels a little odd to still use XGBE_MAC_ADDR_PROPERTY in the error
message when now we support any property name for MAC address.
Let's rewrite the error to "invalid MAC address property\n"
and delete  XGBE_MAC_ADDR_PROPERTY 
-- 
pw-bot: cr
Thread (2 messages) 2 messages, 2 authors, last reply 2026-03-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help